Linter tools (`cpplint`, `checkpatch`, `shellcheck`) should use
`linter.out` as their output file. Fix the `grade.sh` script to use
`linter.out`, instead of the old, wrong `checker.out`.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

These are sample programs to test the mini-libc implementation.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Update `README.md` with current structure of directory (e.g. use `src/`
instead of `libc/`). Detail use of `grade.sh` and `make lint`.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

`grade.sh` automatically grades the assignment based on the checker
(running tests for grading correctness) and linter output (for grading
coding style).

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Alex Apostolescu authored 1 year ago and Razvan Deaconescu committed 1 year ago

Use the absolute path of SRC_PATH in tests/Makefile rather than
prepending ../ when changing directory.

Signed-off-by: Alex Apostolescu <alexx.apostolescu@gmail.com>

Reference solution for implementing `stat()` and `fstat()` relies on
system call being made. Include `internal/syscall.h` in corresponding
source code files to provide the `syscall()` function.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

The `tests/run_all_tests.sh` script uses the `en_US.UTF-8` locale. This
may not be available on certain systems, requiring installation. Replace
it with the use of the generally available `C` locale.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Use `apt update` in the same `RUN` command with `app install`. This
prevents package synchronzation issues during installation.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Ignore `readability/todo` rule. This gives an unpleasant warning to use
`TODO(username)` as part of TODO comment items. Just allow simple `TODO`
comment items.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Ignore `build/include_subdir` rule. This gives a rather abnoxious
warning if you simply include "test.h". It should be written as
"./test.h", but that's uncommon.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Remove spacing between TODO comments and existing code. This is for
consistency throughout the assignment skeleton.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Teodor Juravlea authored 2 years ago and Razvan Deaconescu committed 1 year ago

Changed the implementation of `write()` and `read()` to set `errno`,
as per their manual pages.

Signed-off-by: Teodor Juravlea <teodorjuravlea@gmail.com>

This is compatible with default grading used by VMChecker.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

This is required for floating point formatting, to make sure it uses dot
(`.`). Some languages (such as Romanian) use comma (`,`).

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

This rule creates a Zip archive with the contents of the `src/`
directory (where the solution will be developed). The archive is meant
to be submitted on Moodle.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Add instructions on using the checker: local, remote, Moodle.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

First run `make check`, then `make lint`. This is useful because Moodle
only extract the first 300 lines of output. If `make lint` is first,
that output is typically covered by the linter output, leaving out
students from seeing the checker output (which is more important).

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Copy hidden `.checkpatch.conf` and `.shellcheckrc` in temporary folder
that will be mounted for running Docker interactively.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Replace default DockerHub registry.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>

This improves the visibility of linter messages.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>